Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Simplify controllers resource links #535

Open
taorepoara opened this issue Jan 21, 2024 · 0 comments
Open

[Task] Simplify controllers resource links #535

taorepoara opened this issue Jan 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@taorepoara
Copy link
Member

What should be done

In the current state of the server, we have to check in every controller that the resources in the path match (ex: /apps/:app_id/envs/:env_id have to check that the env id is corresponding to the app id).

In order to handle those checks easily, create a macro automate them in the controllers or as a router function.

Also automate corresponding checks in the unit tests.

Technical recommandation

I think that a plug in the router could be the best way to automate that.

Is this task linked with any other ?

Unit test checking that kind of things have been added to the next issue resolution:

#532 (comment)

@taorepoara taorepoara added the enhancement New feature or request label Jan 21, 2024
@taorepoara taorepoara added this to Lenra Jan 21, 2024
@github-project-automation github-project-automation bot moved this to 🟣 Need triage in Lenra Jan 21, 2024
@taorepoara taorepoara moved this from 🟣 Need triage to 🟡 Backlog in Lenra Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🟡 Backlog
Development

No branches or pull requests

1 participant