Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add checks on logo upload #525

Open
jonas-martinez opened this issue Jan 8, 2024 · 0 comments
Open

[Task] Add checks on logo upload #525

jonas-martinez opened this issue Jan 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jonas-martinez
Copy link
Collaborator

jonas-martinez commented Jan 8, 2024

What should be done

We should add some checks on the logo upload feature. We need to make sure that the developer cannot add enormous logos.
We might want to add an environment variable for that, so that it is possible to change the value of accepted logo size.
Add some error handling in case the logo is overweight.

Be careful because there is already a limit in file upload that applies to all types of files, even images. So if you try to set the max size for an image over this global limit, it might not be able to go over the global limit at upload.

Ecological concerns

We might want to change the way we store the logos because it can become really heavy to do this in postgres (particularly for backups). But this is a problem for another issue 😄

@jonas-martinez jonas-martinez added the enhancement New feature or request label Jan 8, 2024
@github-project-automation github-project-automation bot moved this to 🟣 Need triage in Lenra Jan 8, 2024
@taorepoara taorepoara moved this from 🟣 Need triage to 🟤 Can wait in Lenra Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🟤 Can wait
Development

No branches or pull requests

1 participant