Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Do not need consent for app websocket #490

Open
taorepoara opened this issue Oct 17, 2023 · 0 comments
Open

[Task] Do not need consent for app websocket #490

taorepoara opened this issue Oct 17, 2023 · 0 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@taorepoara
Copy link
Member

What should be done

In the OAuth flow we first ask the user to login and then to consent for the asked scopes.

For external Lenra clients, the only scope asked for is app:websocket that does not really give access to user information.

To give a better user experience to our users we will skip the consent page when the only asked scope is app:websocket.

Technical recommandation

See if Hydra manages skipping consent in the acceptation of the connection.

If not we can validate the consent when loading the consent page, but it's not the best solution.

@taorepoara taorepoara added the enhancement New feature or request label Oct 17, 2023
@taorepoara taorepoara added this to Lenra Oct 17, 2023
@github-project-automation github-project-automation bot moved this to 🟣 Need triage in Lenra Oct 17, 2023
@taorepoara taorepoara moved this from 🟣 Need triage to 🟡 Backlog in Lenra Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
Status: 🟡 Backlog
Development

No branches or pull requests

1 participant