Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuItem's Icon and Text are not aligned #48

Open
jonas-martinez opened this issue Oct 18, 2021 · 4 comments
Open

MenuItem's Icon and Text are not aligned #48

jonas-martinez opened this issue Oct 18, 2021 · 4 comments
Assignees
@dhanvi1911
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@jonas-martinez
Copy link
Contributor

image
As we can see on this image, there is a slight gap under the text of the MenuItem, we might want to align the icon and text.
@jonas-martinez jonas-martinez added the good first issue Good for newcomers label Oct 18, 2021
@ClementGld ClementGld self-assigned this Oct 18, 2021
@ClementGld
Copy link
Contributor

We have to see if we need to redesign the component, for example the space before the text if we have to put it all the time or not. and for the alignment we have to see to modify more in depth or not

@ClementGld ClementGld removed their assignment Oct 18, 2021
@ClementGld ClementGld added help wanted Extra attention is needed question Further information is requested labels Oct 18, 2021
@dhanvi1911
Copy link

Hey, can you assign this issue to me?

@jonas-martinez
Copy link
Contributor Author

@dhanvi1911
Hello,

Sure i'm assigning this issue to you. Thank you for your contribution and don't hesitate to ask questions if you encounter any problem !

Happy coding !

@dhanvi1911
Copy link

Could you send the full Screenshot of the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhanvi1911 dhanvi1911

Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonas-martinez @dhanvi1911 @ClementGld