-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and test encapsulation #33
Comments
I think we have two main ways to handle this:
I'd lean towards pre-building - it's simpler for everyone. For the dynamic building approach, we could leverage GitHub Actions to automate the build process and provide better cross-platform support. |
Regarding your comment about LeanDojo in the article:
LeanDojo has actually been Docker-free for quite some time. It interact with traced repositories, relying on two Lean scripts (Lean4Repl.lean and ExtractData.lean). The Python package serves merely as a wrapper, similar to PyPantograph. The tactic support (such as 'have' and 'calc') is indeed a limitation in LeanDojo, and this makes Pantograph more valuable. :) |
Can the pre-built Pantograph repl run in an environment with no |
I believe not. Perhaps we could adopt the second method - building in Currently, the repository uses git submodules to fetch Lean code, which might take some effort to upload to PyPI. For immediate development needs, I suggest:
This approach could also enable support for multiple versions based on project-specific lean-toolchain requirements. BTW, I get an installation issue when using Conda. One needs to use cp PyPantograph/pantograph/pantograph-repl $HOME/miniconda/envs/pantograph/lib/python3.11/site-packages/pantograph Otherwise, the Python code only works within the This issue would be resolved with the caching approach. |
The interaction bugs are fixed and I'm waiting for user feedback to close the issues and merge the PRs into mainline (deadline by the end of this week). The Lean repl is already in a separate repository, so its separate. I don't use conda, so I will not be able to help you with conda issues. I think you'll have to work with I'll do the housekeeping work after we figure out a stable way to deliver this software to the users. |
I don't know if we can upload this to pypi yet, because the Lean 4 based executable might not be able to run in a standalone environment.
The text was updated successfully, but these errors were encountered: