Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear existing matching items when new exclusion rule is add #46

Open
junkblocker opened this issue Sep 14, 2016 · 2 comments
Open

Clear existing matching items when new exclusion rule is add #46

junkblocker opened this issue Sep 14, 2016 · 2 comments

Comments

@junkblocker
Copy link

When a new exclusion rule is added, existing items matching the new rule should be added. This probably should be done via some sort of preview in case there are typos in the regex/rule or user is not aware of the extent of items it would clear.

@ghost
Copy link

ghost commented Sep 17, 2016

Should the content from the now-excluded website be deleted, or just hidden? If hidden, the content for the site could re-appear when the exclusion rule gets removed. Personally, I think this makes more sense for the exclusion.
If the user wants the context deleted, they should use the delete history function.

@junkblocker
Copy link
Author

@morris-jason , sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant