Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing #29

Open
aazuspan opened this issue May 30, 2023 · 2 comments
Open

Licensing #29

aazuspan opened this issue May 30, 2023 · 2 comments
Milestone

Comments

@aazuspan
Copy link
Contributor

aazuspan commented May 30, 2023

Before release, we need to:

  1. Select a license for sknnr.
  2. Ensure we comply with the license of ported code. We currently port code from:
    1. yaImpute throughout, which is primarily GPL v3 but also contains some public domain code. Their GPL license was inherited and upgraded from the LGPL license of the ANN library.
    2. statsmodels for the implementation of CCorA (although we can hopefully migrate to the sklearn implementation of CCA), which is BSD-3 licensed.
    3. scikit-learn for the implementation of dataset loading, which is BSD-3 licensed.

See #27 for further discussion.

@grovduck
Copy link
Member

For now, throughout the code, we have used the marker REFERENCE in docstrings to denote places where we will need to specify the licensing from ported code. As part of resolving this issue, we need to make sure that we remove these markers and replace them with meaningful licensing information.

@aazuspan aazuspan added this to the 0.1.0 milestone May 31, 2023
@aazuspan
Copy link
Contributor Author

Just came across this 3rd party license file and thought it might be a good approach to use for our licensing--basically have one Markdown file that lists all the licensed code and where/how it's used. We could probably add the full text licenses here too, as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants