Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Behavioral differences in AnnounceAll and last car #1005

Open
JunmoreHeavyBox opened this issue Apr 2, 2024 · 3 comments
Open

Comments

@JunmoreHeavyBox
Copy link
Contributor

JunmoreHeavyBox commented Apr 2, 2024

Description

  • Announce with speed

The axle of each car will trigger a sound, and the rear axle of the last car will not be triggered.

  • AnnounceAll with speed

Only the front axle of each car triggers a sound, while both axles of the last car trigger a sound.

Out of the meaning of "all (axle)", I would like to exchange features with Announce.

  • AnnounceAll without speed

The sound triggered sequentially by the front axle of each car, strangely, both axles of the last car triggered the sound, causing repetition.

This is not the sound event I imagined. What I thinking is for all cars to play simultaneously.

I even think it can be used for pitch fixed joint sounds, but it lacks a rear axle and repeatable triggering.

Funny thing, I made a derailment sound event based on the #997 to entertain myself:)

I want to ask about the difference between DopplerAll.

leezer3 added a commit that referenced this issue Apr 2, 2024
@leezer3
Copy link
Owner

leezer3 commented Apr 2, 2024

Fixed the AnnounceAll rear axle trigger issue, which was unintentional.

Adding a new event type which triggers on all axles would possibly be do-able, although I'm not sure that your joint idea is going to work in a sensible way in terms of performance.

With regards to DopplerAll, I suspect the difference you're seeing is because the train speed is calculated each time the event occurs. If the train speed is changing as each car passes over the event, you'll inevitably get differing pitch values.

@JunmoreHeavyBox
Copy link
Contributor Author

My idea of rail joints will be discussed in the next issue.
I just want to ask about the difference between DopplerAll and the original Doppler, I'm sorry.
AnnounceAll did not trigger any sound in this build.

leezer3 added a commit that referenced this issue Apr 3, 2024
@leezer3
Copy link
Owner

leezer3 commented Apr 3, 2024

Apologies, errant return statement that I thought I'd removed....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants