Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Blocks: Validation error doesn't clear when corrected on child item #315

Open
1 task done
CarlSargunar opened this issue Apr 12, 2023 · 4 comments
Open
1 task done
Labels
bug-report Something isn't working help wanted Extra attention is needed

Comments

@CarlSargunar
Copy link

Which Contentment version are you using?

4.4.2

Which Umbraco version are you using? For example: 8.14.1 - don't just write v8

10.4.2

Bug summary

With nested element types in Data Blocks, validation errors aren't cleared on Publish, but ARE cleared on save.

I've recorded a screencap of me reproducing this error - zipped up as it's too big otherwise

2023-04-12 22-44-24.zip

Steps to reproduce

Set up a data list using contentblocks, with a required field on one of the element types.

  • Try and publish without a required field populated (this works as expected)
  • Update the field to clear the validation error
  • Try and publish - this fails
  • Saving will work, and after saving I can then publish

Expected result / actual result

No response

Do you have Umbraco ModelsBuilder enabled?

  • Yes, it is enabled.

What browsers are you seeing the problem on?

No response

@CarlSargunar CarlSargunar added the bug-report Something isn't working label Apr 12, 2023
@CarlSargunar
Copy link
Author

Happy to help try and fix this - but I'd need some pointers to know where to start looking (angularJS is not my strongest)

@leekelleher
Copy link
Owner

Thanks for raising this @CarlSargunar.

This could be with the server-side validation for Content Blocks that I'd added in v4.4.2, commit: 7706d88
I'd tried to follow the same pattern as Umbraco's BlockList and NestedContent, so I'm unsure why it wouldn't re-validate on Publish, but it does for Save. 🤔 (I'll give it some thought.)

@leekelleher leekelleher added help wanted Extra attention is needed Hacktoberfest Issues open for Hacktoberfest contributions labels Sep 28, 2023
@leekelleher leekelleher removed the Hacktoberfest Issues open for Hacktoberfest contributions label Nov 3, 2023
@Deba22
Copy link

Deba22 commented Mar 18, 2024

Hi @leekelleher @CarlSargunar

I am facing the same issue in contentment v4.4.5. Just checking if this has been resolved?

@leekelleher
Copy link
Owner

@Deba22 Unfortunately it hasn't been resolved. I was able to reproduce the issue, but unable to figure out how to fix it.
It's open for community help if anyone else knows how to fix it.

@leekelleher leekelleher changed the title Validation error doesn't clear when corrected on child item of ContentBlocks Datatype Content Blocks: Validation error doesn't clear when corrected on child item Mar 18, 2024
@leekelleher leekelleher removed their assignment Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants