Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing relu at line 57 in cnn.py in a5_public #14

Open
yagebu90 opened this issue Sep 18, 2020 · 0 comments
Open

missing relu at line 57 in cnn.py in a5_public #14

yagebu90 opened this issue Sep 18, 2020 · 0 comments

Comments

@yagebu90
Copy link

yagebu90 commented Sep 18, 2020 •
edited
Loading

Hi, nice sharing. A small typo in calculating the final output X_{conv_out} of convolutional network. According to equation (7) of a5.pdf, there should be a relu before implementing maxpool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yagebu90