Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definitions (typescript & flow) for jasmine-check package #80

Open
vholovko opened this issue Apr 10, 2018 · 4 comments
Open

Type definitions (typescript & flow) for jasmine-check package #80

vholovko opened this issue Apr 10, 2018 · 4 comments
Milestone
1.0.0

Comments

@vholovko
Copy link

vholovko commented Apr 10, 2018 •
edited
Loading

jasmine-check.d.ts cannot be found in the latest distribution 1.0.0-rc.0

untitled

untitled1

untitled1

The library is great but I cannot use it with TypeScript and Jest without first having jasmine-check.d.ts.
Please place it in the same root directory as jasmine-check.ts.
Thanks!
@leebyron leebyron changed the title Cannot find name 'check': Type definitions is missing in jasmine-check npm package Type definitions (typescript & flow) for jasmine-check package Apr 14, 2018
@leebyron
Copy link
Owner

Update on this: master has the type definitions for typescript, but does not yet have them for flow. This is a 1.0-blocker.

@leebyron leebyron added this to the 1.0.0 milestone Apr 14, 2018
@jasonkuhrt
Copy link

Just confirming that the currently published files are missing the typings:

❯ ls node_modules/jasmine-check
LICENSE			README.md		jasmine-check.js	package.json

@jasonkuhrt
Copy link

@leebyron seems like a quickfix, shall I submit a pr or is there more complexity not apparent from this issue?

@sesm
Copy link

sesm commented Jun 12, 2018

@jasonkuhrt I'm not @leebyron, but please, submit a PR for this!

@chesedo chesedo mentioned this issue Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
4 participants
@leebyron @jasonkuhrt @sesm @vholovko