Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom fee setting for transactions by app #2566

Open
markmhendrickson opened this issue Jul 15, 2022 · 3 comments
Open

Support custom fee setting for transactions by app #2566

markmhendrickson opened this issue Jul 15, 2022 · 3 comments
Labels
area:fees enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Jul 15, 2022 •
edited
Loading

As request by @unclemantis with hirosystems/connect#176 (comment).

We previously had this functionality but removed it for lack of perceived usage and need at the time given improved fee estimates, but it still may serve particular use cases.

Note that we may want to warn the user clearly when an app has suggested a custom fee so they don't get surprised by accidentally submitting a transaction with a (potentially large) fee they don't intend as a user.
@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p2 Critical functionality needed by few users, with no clear alternatives area:fees labels Jul 15, 2022
@markmhendrickson markmhendrickson mentioned this issue Jul 15, 2022
Open
@aulneau
Copy link
Contributor

aulneau commented Jul 15, 2022

Curious if it makes sense to allow an advanced mode for the wallet to accept an unsigned StacksTransaction instance, that is then parsed by the wallet and ultimately signed by the user? For advanced apps this would be really useful.

@unclemantis
Copy link

unclemantis commented Jul 16, 2022 •
edited
Loading

Greetings earthlings! I will be following this issue closely and will be participating politely. it is great that I have been heard!

Let me know how I can contribute. DevOp and HUGE Stacks fan.

two days and no additional hooks!? common! LFG!

unclemantis.btc

@unclemantis
Copy link

Bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:fees enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@markmhendrickson @unclemantis @kyranjamie @aulneau