Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden node viewset to ensure missing data sets it incomplete #4173

Closed
bjester opened this issue Jun 23, 2023 · 1 comment · Fixed by #4627
Closed

Harden node viewset to ensure missing data sets it incomplete #4173

bjester opened this issue Jun 23, 2023 · 1 comment · Fixed by #4627
Assignees
Labels
DEV: backend P1 - important Priority: High impact on UX

Comments

@bjester
Copy link
Member

bjester commented Jun 23, 2023

Observed behavior

There seemed to be a gap in our validation and viewset logic that allowed a node to be marked as complete, even though it did not have proper mastery criteria. This resulted in a failure during publishing
#4163

Expected behavior

We harden the content node viewset to ensure that completion criteria sets the node incomplete when it's invalid.

User-facing consequences

Users don't have insight within the UI regarding which nodes are incomplete and won't be published

@rtibbles
Copy link
Member

Should make sure we are leveraging the mark_complete function here: https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/models.py#L1810, and that it is properly applying any updates (it's possible that the slightly over complicated logic in the viewset/serializer logic is not passing complete as a field to be saved).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants