Skip to content

Conversation

@rtibbles
Copy link
Member

Summary

  • Updates morango to version that has syncing_objects as the manager used for Morango syncing
  • Adds syncing_objects to Collection proxy classes to ensure proper filtering of synced collections
  • Updates the public SyncQueue endpoint allows soft deleted, deleted, and hard deleted users to still queue for a sync, to ensure that their deletion can be propagated to an LoD.
  • Adds tests to cover soft deleted users being able to use the sync queue, and deleted, and hard deleted users that have and have not been serialized to the store.

References

This was noticed by @AlexVelezLl while implementing #13759

Reviewer guidance

All production code implementation was done by hand - initial tests were written by Claude Code and then tweaked.

Have I covered every possibility for the sync cases? Will allowing the SyncQueue actually allow the sync to happen, or do we need more tweaks for that?

Hrm, to answer my own question, I think we might need more.

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: medium labels Sep 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

@rtibbles
Copy link
Member Author

Hrm, postgres still complaining about transaction isolation in the test. Will try to find a better way to handle this.

Add test of single user syncing propagation.
Update syncing_objects manager to proxy aware manager.
@rtibbles rtibbles marked this pull request as ready for review September 30, 2025 17:40
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me

@rtibbles rtibbles merged commit 2201221 into learningequality:develop Sep 30, 2025
57 checks passed
@rtibbles rtibbles deleted the morango_upgrade branch September 30, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV: backend Python, databases, networking, filesystem... SIZE: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants