-
Notifications
You must be signed in to change notification settings - Fork 828
Morango upgrade and sync queue tweaks #13774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Build Artifacts
|
bjester
reviewed
Sep 24, 2025
bjester
reviewed
Sep 24, 2025
0b6ad8b to
3c53753
Compare
Member
Author
|
Hrm, postgres still complaining about transaction isolation in the test. Will try to find a better way to handle this. |
Add test of single user syncing propagation. Update syncing_objects manager to proxy aware manager.
3c53753 to
05aaa39
Compare
…d deleted users can all queue for a sync.
2269468 to
6eac271
Compare
bjester
approved these changes
Sep 30, 2025
Member
bjester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
This was noticed by @AlexVelezLl while implementing #13759
Reviewer guidance
All production code implementation was done by hand - initial tests were written by Claude Code and then tweaked.
Have I covered every possibility for the sync cases? Will allowing the SyncQueue actually allow the sync to happen, or do we need more tweaks for that?
Hrm, to answer my own question, I think we might need more.