Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KLiveRegion and useKLiveRegion in Kolibri #12326

Open
MisRob opened this issue Jun 20, 2024 · 2 comments
Open

Use KLiveRegion and useKLiveRegion in Kolibri #12326

MisRob opened this issue Jun 20, 2024 · 2 comments
Assignees
@MisRob

Comments

@MisRob
Copy link
Member

MisRob commented Jun 20, 2024

Blocked by

learningequality/kolibri-design-system#668

Summary

Refactor Kolibri to use <KLiveRegion> and its companion useKLiveRegion for reasons mentioned in learningequality/kolibri-design-system#668.

Current live regions in Kolibri:

  • (1) aria-live
  • (2) role="alert"
    • search results
    • roughly corresponds to assertive aria-live but with added semantic meaning as on some screen readers it prepends announcements with “Alert: …”
  • (3) role="timer"
@MisRob MisRob mentioned this issue Jun 20, 2024
Open
@MisRob
Copy link
Member Author

MisRob commented Jun 20, 2024

To decide/discuss

  • Should <KLiveRegion> also support the timer role (3) or is it best to leave that one extra live region as is?
  • Is there a place where we could put <KLiveRegion> in Kolibri so that it takes effect for all plugins, or should each plugin include it?

@MisRob MisRob added the TODO: needs decisions Design or specifications are necessary label Jun 20, 2024
@MisRob MisRob self-assigned this Jun 20, 2024
@MisRob MisRob changed the title Proposal: Use KLiveRegion and useKLiveRegion in Kolibri Use KLiveRegion and useKLiveRegion in Kolibri Jul 10, 2024
@MisRob MisRob removed the TODO: needs decisions Design or specifications are necessary label Jul 10, 2024
@MisRob
Copy link
Member Author

MisRob commented Jul 10, 2024

Decisions:

  • Won't add timer role. Reason: There's just one use-case. Would be good to QA how it plays together with the global live region though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MisRob MisRob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MisRob