Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KListWithOverflow]: Add unit tests #833

Open
AlexVelezLl opened this issue Nov 19, 2024 · 2 comments
Open

[KListWithOverflow]: Add unit tests #833

AlexVelezLl opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels

Comments

@AlexVelezLl
Copy link
Member

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Product

KDS.

Desired behavior

We should add unit tests to KListWithOverflow, since it has some complicated calculations and needs to be protected from regressions. So we need to test at least the following things:

  • It should render the whole list items if it fits in the available space, even if there is just 1px of difference.
  • It shouldnt render the more slot if the list items fits in the available space.
  • It shouldnt render the items that are overflowed and dont fit in the available space even if there is just 1px of difference.
  • It should render the more slot if there are overflowed items.
  • It should pass the correct items in the overflowItems array passed to the more slot.
  • It shouldnt render a divider as the last item in the visible list, even if it fits in the available space.

Current behavior

We currently dont have unit tests for KListWithOverflow.

@yeshwanth235
Copy link
Contributor

Hi @AlexVelezLl , I would like to work on this issue. Please assign to me.

@LianaHarris360
Copy link
Member

Hey @yeshwanth235 thank you for your interest in handling this issue, I can assign it to you. Please let us know if you have any questions! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants