Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#741 Removed border-radius on align left #747

Closed
wants to merge 2 commits into from

Conversation

Spoorthy1423
Copy link
Contributor

@Spoorthy1423 Spoorthy1423 commented Aug 23, 2024

#741 Removed border-radius on align left
Removed unused sections and

Removed border-radius when the thumbnail display is align left using thumbnailAlign prop and made thumbnail prop large.

Description

Issue addressed

Addresses #PR# HERE

Before/after screenshots

Changelog

  • [#PR no]
    • Description: Summary of change(s)
    • Products impact: Choose from - none (for internal updates) / bugfix / new API / updated API / removed API. If it's 'none', use "-" for all items below to indicate they are not relevant.
    • Addresses: Link(s) to GH issue(s) addressed. Include KDS links as well as links to related issues in a consumer product repository too.
    • Components: Affected public KDS component. Do not include internal sub-components or documentation components.
    • Breaking: Will this change break something in a consumer? Choose from: yes / no
    • Impacts a11y: Does this change improve a11y or adds new features that can be used to improve it? Choose from: yes / no
    • Guidance: Why and how to introduce this update to a consumer? Required for breaking changes, appreciated for changes with a11y impact, and welcomed for non-breaking changes when relevant.

[#PR no]: PR link

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@MisRob
Copy link
Member

MisRob commented Aug 23, 2024

Hello @Spoorthy1423, you need to adjust KCard.vue component. Here you updated its documentation page - these changes will need to be reverted. I recommend you check out the linked contributions guidelines that contain links to dev docs that will help you to understand this repository and how to develop.

@Spoorthy1423
Copy link
Contributor Author

Hey!! @MisRob i would love to work, on this issue further, can u please explain me the steps need to be taken

@Spoorthy1423 Spoorthy1423 closed this by deleting the head repository Aug 24, 2024
@MisRob
Copy link
Member

MisRob commented Aug 24, 2024

Hi @Spoorthy1423. first begin with reading carefully the materials I referenced and familiarize yourself with how the library and the documentation works and what's difference between the two. Then you can find the place where thumbnail's area border radius is defined in lib/KCard in the given layout and update it there. I'd ask you to only submit changes that directly solve the task and also post before/after screenshots to the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants