Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visual Testing]: Implement visual tests of KButton #689

Closed
AlexVelezLl opened this issue Jul 26, 2024 · 3 comments
Closed

[Visual Testing]: Implement visual tests of KButton #689

AlexVelezLl opened this issue Jul 26, 2024 · 3 comments
Assignees

Comments

@AlexVelezLl
Copy link
Member

AlexVelezLl commented Jul 26, 2024

Product

KDS.

Desired behavior

After #685, we ended up with a very straightforward way of writting visual tests. Now lets implement exhaustive tests for one component - KButton, and test the whole visual tests process with this component.

We should take the snapshot of the different visual combinations of KButton:

  • KButton as primary raised button
  • KButton as primary flat button
  • KButton as secondary raised button
  • KButton as secondary flat button
  • KButton as basic link
  • KButton as raised button disabled
  • KButton as flat button disabled
  • KButton as raised button with hover state
  • KButton as flat button with hover state
  • KButton with icon and afterIcon
  • KButton with default slot

Current behavior

Currently we just have the basic example with default props.

@KshitijThareja
Copy link
Contributor

Hi @AlexVelezLl
Thanks for creating the issue. I'll try to create a PR for this soon :)

@AlexVelezLl
Copy link
Member Author

Thank you @KshitijThareja!

@AlexVelezLl
Copy link
Member Author

Closed by #710.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants