[WIP] Use isAppContext to determine if we're in an embedded WebView… #7663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Mac, and Android.
…olibri into win_app_check
… dependency issues.
Codecov Report
|
jonboiser
reviewed
Nov 17, 2020
| @@ -38,7 +38,7 @@ | |||
|
|
|||
| <script> | |||
|
|
|||
| import { isEmbeddedWebView } from 'kolibri.utils.browserInfo'; | |||
| import { isEmbeddedWebView } from 'kolibri.utils.appInfo'; | |||
There was a problem hiding this comment.
isEmbddedWebView needs to be called as function on line 56 below
|
Closing this PR as this approach will take more work than anticipated, and given that it is probably better to just focus on switching to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on Win, Mac, and Android.
Summary
Fixes learningequality/kolibri-app#68 (comment)
Marking this as WIP until I can get built packages to try out in the apps.
Reviewer guidance
Check that within the app, download buttons do not appear, but that they do appear when run in the browser.
References
…
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarnandpip)