Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic Tree loads from the outside in with multiple API requests #4392

Closed
rtibbles opened this issue Sep 8, 2015 · 9 comments
Closed

Topic Tree loads from the outside in with multiple API requests #4392

rtibbles opened this issue Sep 8, 2015 · 9 comments
Assignees
Milestone

Comments

@rtibbles
Copy link
Member

rtibbles commented Sep 8, 2015

Expected Behaviour: Sidebar should load all the data needed at once, rather than multiple API requests.

Current Behaviour: Sidebar parses each slug in the path and loads the data incrementally, rather than fetching all the data needed at once.

@rtibbles rtibbles self-assigned this Sep 8, 2015
@rtibbles rtibbles added this to the 0.16.0 milestone Sep 8, 2015
@66eli77
Copy link
Contributor

66eli77 commented Sep 8, 2015

@rtibbles you can assign this to me if you like.

@MCGallaspy
Copy link
Contributor

Do you mean that currently there is one request per sidebar entry, and the desired behavior is that all visible sidebar entries are fetched in one request?

@rtibbles
Copy link
Member Author

rtibbles commented Sep 8, 2015

yep

@rtibbles
Copy link
Member Author

rtibbles commented Sep 8, 2015

Wait, no. One request per sidebar level.

@rtibbles rtibbles modified the milestones: 0.17.0, 0.16.0 Feb 1, 2016
@rtibbles rtibbles assigned 66eli77 and unassigned rtibbles Feb 1, 2016
@66eli77
Copy link
Contributor

66eli77 commented Feb 16, 2016

did we load all the data needed at once in previous kalite?

@rtibbles
Copy link
Member Author

@66eli77 previously we loaded ALL THE DATA at once, even stuff we didn't need.

What we should do here is load only the data we do need, the motivation for loading one level at a time is to make sure we show the user relevant data fast - but the way to do this is not to load the topmost sidebar level first, but the innermost one, and then fill in the others.

@rtibbles
Copy link
Member Author

Also, note: this is slated for 0.17, so no need to do now timecrunch wise.

@66eli77
Copy link
Contributor

66eli77 commented Feb 16, 2016

kk

@radinamatic radinamatic modified the milestones: 0.17.0, 0.18 Jan 15, 2017
@benjaoming
Copy link
Contributor

This would be great to have done, but we don't seem to have any performance issues related to it. The closest I can think of is #5254

Closing this as we are preparing to become more stable etc in the time coming :) As KA Lite works fine with this tweak, we can probably expect that it won't ever be a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants