-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic Tree loads from the outside in with multiple API requests #4392
Comments
@rtibbles you can assign this to me if you like. |
Do you mean that currently there is one request per sidebar entry, and the desired behavior is that all visible sidebar entries are fetched in one request? |
yep |
Wait, no. One request per sidebar level. |
did we load all the data needed at once in previous kalite? |
@66eli77 previously we loaded ALL THE DATA at once, even stuff we didn't need. What we should do here is load only the data we do need, the motivation for loading one level at a time is to make sure we show the user relevant data fast - but the way to do this is not to load the topmost sidebar level first, but the innermost one, and then fill in the others. |
Also, note: this is slated for 0.17, so no need to do now timecrunch wise. |
kk |
This would be great to have done, but we don't seem to have any performance issues related to it. The closest I can think of is #5254 Closing this as we are preparing to become more stable etc in the time coming :) As KA Lite works fine with this tweak, we can probably expect that it won't ever be a priority. |
Expected Behaviour: Sidebar should load all the data needed at once, rather than multiple API requests.
Current Behaviour: Sidebar parses each slug in the path and loads the data incrementally, rather than fetching all the data needed at once.
The text was updated successfully, but these errors were encountered: