Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Droplets theme #3814

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Droplets theme #3814

wants to merge 17 commits into from

Conversation

willgearty
Copy link
Member

@willgearty willgearty commented Jan 19, 2025

This is the start of a new theme, based largely on bigpicture, called "droplets", named after the dropdown nav menus. It includes the following improvements:

  • Fixed navbar that stays at the top of the screen even when scrolling
  • Dropdown navigation menus
  • Admin toolbar, morph details, and login info/form integrated into navbar
  • Supports glyphicons for dropdown options
  • Increases width of main content to full width of screen
  • Responsive to device screen size (including the navbar turning into a collapsed vertical menu)

Still to be done:

  • Clean up admin toolbar dropdown styles?
  • Fix up theme tests?
  • Navbar dropdown headers don't support links since clicking them opens the dropdown (we could just modify the theme editor to be clear about this or figure out a way to allow for actual links)
  • Integrate bootstrap variables? (@kkbrum is more familiar with this than I am)
  • Make and integrate optional variables to alter navbar appearance?
  • Check how lots of pages look with full screen width
  • Use the width better on the manage program page
  • Use the width better on the program dashboard
  • Check compatibility of responsive.css on other themes
  • Make the top navbar still have the learn and teach tabs while on the help page
  • Move contact info either to footer or to the arrow dropdown (which would need a name)
  • Make the big picture only show on the homepage (although, with the contact info moved away, the header isn't as big)
  • Make sure the navbar looks good on different size devices
  • On mobile, you can only click nav links once???

While making this theme responsive, I discovered that all we needed to do to make other themes responsive was to compile an additional bootstrap file. Since this is now included in theme_compiled.css, I've removed the line pulling bootstrap from the CDN which apparently wasn't doing anything.

image

@willgearty
Copy link
Member Author

willgearty commented Feb 5, 2025

I've moved the contact info to another dropdown, but moving it to the footer and changing the footer to be static (at the bottom of all content) instead of fixed (always visible) may be a better design and aligns with most modern websites (but may perhaps require slightly more effort by users).

@willgearty
Copy link
Member Author

Also, maybe we want to make the dropdown menus like the ones here: https://sustainability.stanford.edu/. This way we would still have the text link to pages and the dropdown would be a separate button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants