Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme icon fixes #3816

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Theme icon fixes #3816

merged 3 commits into from
Jan 31, 2025

Conversation

willgearty
Copy link
Member

This fixes two issues for theme navigation icons (used by bigpicture and droplets):

  1. Most of the icons in the dropdown weren't rendering properly
  2. Changing the icon wasn't being saved in the theme settings (Fixes Can't save bigpicture navigation icons #3812)

@willgearty willgearty added this to the Stable Release 16 fixes milestone Jan 24, 2025
@willgearty willgearty requested a review from kkbrum January 24, 2025 03:29
@kkbrum
Copy link
Contributor

kkbrum commented Jan 31, 2025

The dropdown renders nicely. However, if I click an option, then the selection doesn't render the icon.
image

@willgearty willgearty merged commit fdf0a0b into main Jan 31, 2025
5 checks passed
@willgearty willgearty deleted the theme-icon-fix branch January 31, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkbrum kkbrum kkbrum approved these changes

Assignees

@willgearty willgearty

Labels
Themes
Projects
None yet
Milestone
Stable Release 16 fixes
Development

Successfully merging this pull request may close these issues.

Can't save bigpicture navigation icons
2 participants
@willgearty @kkbrum