Skip to content

Commit 1353f7b

Browse files
authored
Merge pull request #4 from kabirbaidhya/jsdoc-improvements
Improvements on the JSDoc rules to not require js doc for anonymous functions and expressions
2 parents bf1d3fd + dc66f78 commit 1353f7b

File tree

3 files changed

+16
-56
lines changed

3 files changed

+16
-56
lines changed

eslint.json

Lines changed: 14 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
{
2-
"extends": [
3-
"eslint:recommended"
4-
],
5-
"plugins": [
6-
"jsdoc"
7-
],
2+
"extends": ["eslint:recommended"],
3+
"plugins": ["jsdoc"],
84
"rules": {
95
"brace-style": "error",
106
"camelcase": "error",
@@ -16,14 +12,8 @@
1612
}
1713
],
1814
"curly": "error",
19-
"eol-last": [
20-
"error",
21-
"always"
22-
],
23-
"eqeqeq": [
24-
"error",
25-
"always"
26-
],
15+
"eol-last": ["error", "always"],
16+
"eqeqeq": ["error", "always"],
2717
"indent": [
2818
"error",
2919
2,
@@ -40,19 +30,13 @@
4030
"jsdoc/require-param-type": "error",
4131
"jsdoc/valid-types": "error",
4232
"key-spacing": "error",
43-
"linebreak-style": [
44-
"error",
45-
"unix"
46-
],
33+
"linebreak-style": ["error", "unix"],
4734
"newline-before-return": "error",
4835
"no-await-in-loop": "error",
4936
"no-console": [
5037
"error",
5138
{
52-
"allow": [
53-
"warn",
54-
"error"
55-
]
39+
"allow": ["warn", "error"]
5640
}
5741
],
5842
"no-multi-spaces": "error",
@@ -64,33 +48,18 @@
6448
}
6549
],
6650
"no-var": "error",
67-
"object-curly-spacing": [
68-
"error",
69-
"always"
70-
],
51+
"object-curly-spacing": ["error", "always"],
7152
"padding-line-between-statements": [
7253
"error",
7354
{
7455
"blankLine": "always",
75-
"prev": [
76-
"const",
77-
"let",
78-
"var"
79-
],
56+
"prev": ["const", "let", "var"],
8057
"next": "*"
8158
},
8259
{
8360
"blankLine": "any",
84-
"prev": [
85-
"const",
86-
"let",
87-
"var"
88-
],
89-
"next": [
90-
"const",
91-
"let",
92-
"var"
93-
]
61+
"prev": ["const", "let", "var"],
62+
"next": ["const", "let", "var"]
9463
}
9564
],
9665
"prefer-const": [
@@ -116,20 +85,14 @@
11685
"FunctionDeclaration": true,
11786
"MethodDefinition": true,
11887
"ClassDeclaration": true,
119-
"ArrowFunctionExpression": true,
120-
"FunctionExpression": true
88+
"ArrowFunctionExpression": false,
89+
"FunctionExpression": false
12190
}
12291
}
12392
],
124-
"semi": [
125-
"error",
126-
"always"
127-
],
93+
"semi": ["error", "always"],
12894
"space-before-blocks": "error",
129-
"spaced-comment": [
130-
"error",
131-
"always"
132-
],
95+
"spaced-comment": ["error", "always"],
13396
"space-infix-ops": "error"
13497
}
13598
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"eslint.json"
1616
],
1717
"scripts": {
18-
"precommit": "npm run lint",
18+
"precommit": "yarn lint",
1919
"lint": "eslint -c react.json check.js"
2020
},
2121
"keywords": [

react.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
{
2-
"extends": [
3-
"./eslint.json",
4-
"plugin:react/recommended"
5-
],
2+
"extends": ["./eslint.json", "plugin:react/recommended"],
63
"rules": {}
74
}

0 commit comments

Comments
 (0)