Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: reservoir not listing my package #31

Open
somombo opened this issue May 7, 2024 · 3 comments
Open

bug: reservoir not listing my package #31

somombo opened this issue May 7, 2024 · 3 comments
Labels
A-search Area: Package search. PRs without this will skip searching. C-bug Category: A bug. C-enhancement Category: Issue requires a new feature.

Comments

@somombo
Copy link

somombo commented May 7, 2024

Reservoir updates its index approximately daily. If your package meets the above conditions, but does not appear on Reservoir after a few days, you can report this as a bug on Reservoir's issue tracker.

I believe my package swaps-perm meets all the required criteria but still has not shown up after several days.

cc @tydeu

@tydeu
Copy link
Member

tydeu commented May 7, 2024

Reservoir uses the following GH API invocation to search for Lean/Lake packages:

gh api search/code --paginate --cache 1h -X GET -f 'q=filename:lake-manifest.json path:/' -q '.items[] | .repository.node_id'

If you try the following variant of that command, you can get a sorted listing of the repositories it finds:

gh api search/code --paginate --cache 1h -X GET -f 'q=filename:lake-manifest.json path:/' -q '.items[] | "\(.repository.owner.login)/\( .repository.name)"' | sort

For a reason I am not clear on, GitHub is not including your swaps-perm package in these search results. However, It does include your murder-mystery and supertype repositories in the results.

The good news is I will be working on a manual registration process on my end soon. That way I can add packages even if they do not surface in GitHub for some reason. But until then, Reservoir is constrained by what GitHub search chooses to return. I apologize for the inconvenience. 😞

@tydeu tydeu added C-bug Category: A bug. C-enhancement Category: Issue requires a new feature. and removed C-enhancement Category: Issue requires a new feature. labels May 7, 2024
@joneugster
Copy link

I believe https://github.com/hhu-adam/lean-i18n is also meeting all criterias but is not included.

@tydeu tydeu added the A-index Area: Package index. PRs without this will skip indexing. label Jul 22, 2024
@siddhartha-gadgil
Copy link

I believe https://github.com/leanprover-community/LeanSearchClient is also being missed

@tydeu tydeu added A-search Area: Package search. PRs without this will skip searching. and removed A-index Area: Package index. PRs without this will skip indexing. labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-search Area: Package search. PRs without this will skip searching. C-bug Category: A bug. C-enhancement Category: Issue requires a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants