Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RingTheory/Ideal/Pointwise): Make Ideal.IsPrime.smul into an instance #18241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Oct 26, 2024

This PR makes Ideal.IsPrime.smul into an instance (like how Ideal.IsPrime.comap is an instance).


Open in Gitpod

@tb65536 tb65536 added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI t-algebra Algebra (groups, rings, fields, etc) labels Oct 26, 2024
Copy link

PR summary 075fe7eca3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@tb65536 tb65536 added the FLT part of the ongoing formalization of Fermat's Last Theorem label Oct 28, 2024
@tb65536 tb65536 mentioned this pull request Oct 28, 2024
12 tasks
@riccardobrasca
Copy link
Member

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 075fe7e.
There were significant changes against commit cd1f493:

  Benchmark      Metric                 Change
  =====================================================
- build          .olean serialization     9.6%
- build          import                  11.1%
- build          initialization           8.4%
- open Mathlib   task-clock              15.8% (16.3 σ)

@riccardobrasca
Copy link
Member

Can you please merge master and see if bench gives the same results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. FLT part of the ongoing formalization of Fermat's Last Theorem t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants