Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non deterministic result on LdbcSnbShortRead Generator due to replenish #117

Open
filipecosta90 opened this issue Feb 3, 2020 · 3 comments
Labels

Comments

@filipecosta90
Copy link

filipecosta90 commented Feb 3, 2020

Hi there,
Considering that the inputs of short queries 1 to 7 are dependent upon the replenish of Complex queries output how can we ensure that two distinct runs will issue the same queries?
That said, If I replenish personIds and messageIds for the short Ids buffers from complex querie 2 it will have a different input if I replenish from complex querie 7.
Please denote https://github.com/ldbc/ldbc_snb_driver/blob/master/src/main/java/com/ldbc/driver/workloads/ldbc/snb/interactive/LdbcSnbShortReadGenerator.java#L531

With that in mind we can produce performance results with different values for the same queries that influenced by the complex queries.
Would it be better if we generated the input for short queries in the same manner we do it for Complex and BI ones?

@szarnyasg
Copy link
Member

@filipecosta90 thanks for the suggestion, we'll discuss it tomorrow with the task force.

@szarnyasg
Copy link
Member

Considering that the inputs of short queries 1 to 7 are dependent upon the replenish of Complex queries output how can we ensure that two distinct runs will issue the same queries?

Btw, given the same input parameters, the results of complex queries are deterministic. So why would two runs yield different results?

@filipecosta90
Copy link
Author

Considering that the inputs of short queries 1 to 7 are dependent upon the replenish of Complex queries output how can we ensure that two distinct runs will issue the same queries?

Btw, given the same input parameters, the results of complex queries are deterministic. So why would two runs yield different results?

Hi there @szarnyasg , considering that for benchmark 1 we only enable Interactive Complex 2 and all short queries and for benchmark 2 we only enable Interactive Complex 7 and all short queries. Wont the input used for short queries vary?
We can keep determinism if we always use the same Complex query to replenish uppon but even on that case we're not able to ensure order ( only when using a single thread ).
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants