Merge pull request #73 from pamil/moar-tests

Test & fix assertResponseContent for incorrect response given

Author: lchrusciel

src/ApiTestCase.php

@@ -195,7 +195,8 @@ protected function assertResponseContent($actualResponse, $filename, $mimeType)
         $actualResponse = trim($actualResponse);
         $expectedResponse = trim(file_get_contents(PathBuilder::build($responseSource, sprintf('%s.%s', $filename, $mimeType))));
 
-        $result = (new SimpleFactory())->createMatcher()->match($actualResponse, $expectedResponse);
+        $matcher = (new SimpleFactory())->createMatcher();
+        $result = $matcher->match($actualResponse, $expectedResponse);
 
         if (!$result) {
             $diff = new \Diff(explode(PHP_EOL, $expectedResponse), explode(PHP_EOL, $actualResponse), []);

test/src/Tests/Controller/SampleControllerJsonTest.php

@@ -12,6 +12,7 @@
 namespace Lakion\ApiTestCase\Test\Tests\Controller;
 
 use Lakion\ApiTestCase\JsonApiTestCase;
+use PHPUnit_Framework_AssertionFailedError;
 
 /**
  * @author Łukasz Chruściel <[email protected]>
@@ -27,6 +28,18 @@ public function testGetHelloWorldResponse()
         $this->assertResponse($response, 'hello_world');
     }
 
+    /**
+     * @expectedException PHPUnit_Framework_AssertionFailedError
+     */
+    public function testGetHelloWorldIncorrectResponse()
+    {
+        $this->client->request('GET', '/');
+
+        $response = $this->client->getResponse();
+
+        $this->assertResponse($response, 'incorrect_hello_world');
+    }
+
     public function testGetHelloWorldWithMatcherResponse()
     {
         $this->client->request('GET', '/');

test/src/Tests/Controller/SampleControllerXmlTest.php

@@ -12,6 +12,7 @@
 namespace Lakion\ApiTestCase\Test\Tests\Controller;
 
 use Lakion\ApiTestCase\XmlApiTestCase;
+use PHPUnit_Framework_AssertionFailedError;
 
 /**
  * @author Arkadiusz Krakowiak <[email protected]>
@@ -27,6 +28,18 @@ public function testGetHelloWorldResponse()
         $this->assertResponse($response, 'hello_world');
     }
 
+    /**
+     * @expectedException PHPUnit_Framework_AssertionFailedError
+     */
+    public function testGetHelloWorldIncorrectResponse()
+    {
+        $this->client->request('GET', '/');
+
+        $response = $this->client->getResponse();
+
+        $this->assertResponse($response, 'incorrect_hello_world');
+    }
+
     public function testGetHelloWorldWithMatcherResponse()
     {
         $this->client->request('GET', '/');

test/src/Tests/Responses/Expected/incorrect_hello_world.json

@@ -0,0 +1,3 @@
+{
+    "message": "Iron Maiden can't be fought!"
+}

test/src/Tests/Responses/Expected/incorrect_hello_world.xml

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<greetings>Iron Maiden can't be sought!</greetings>