Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round corners #27

Open
stsdc opened this issue Dec 18, 2020 · 10 comments
Open

Round corners #27

stsdc opened this issue Dec 18, 2020 · 10 comments

Comments

@stsdc
Copy link
Contributor

stsdc commented Dec 18, 2020

I don't know if this is a limitation of Gtk3 or Cairo, but I'm unable to create proper round corners with border.

image

As You can see on screenshot it is not properly cropped. 😕

Alain managed to create round corners, but it was only possible when paddings were added.

@lcallarec
Copy link
Owner

Yes, AFAIK it's a common issue with most gtk widgets.

You could try this :

But this solution has a drawback : chart's lines will still overflow the corners if they cross... But maybe it's gona be good enough for your case ?

If it's not, I'll fix that in LiveChart itself...

@stsdc
Copy link
Contributor Author

stsdc commented Dec 19, 2020

Yeah, it works. But line overlaps a border line:( I presume grid will too.
image

@stsdc
Copy link
Contributor Author

stsdc commented Dec 19, 2020

Here it is almost perfect:
image

@lcallarec
Copy link
Owner

Do you consider that's good enough and nothing should be done on livechart side ?

@stsdc
Copy link
Contributor Author

stsdc commented Dec 23, 2020

I mean, this is more like a wish 😅

it would be nice to have the line cropped. If the line will be thicker bad cropping will be more noticeable.

If you will consider this out of scope because it should be supported by Gtk or Cairo, I'll understand.

@lcallarec
Copy link
Owner

I'll take a look about adding rounded corners, but not sure it's gonna work...

@stsdc
Copy link
Contributor Author

stsdc commented Jan 8, 2021

This may be related. I see round corners on a screenshot 👀.

@lcallarec
Copy link
Owner

Hi! @stsdc ! Just for information, I'll have some free time to work on this issue in the next weeks. Stay tuned :)

@stsdc
Copy link
Contributor Author

stsdc commented Mar 7, 2022

Yay! ☺️

Just FYI, There are rumors that overflow issues might be fixed in GTK4. I don't know if that's the case for a cairo based widget, tho.

@stsdc
Copy link
Contributor Author

stsdc commented Oct 13, 2024

So, GTK4 didn't fix the issue.
Maybe this solution will be handy: https://github.com/ensemblesaw/ens-shell-gtk/blob/layout/src/Classes/Widgets/Display/EqualizerBar.vala#L58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants