Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Herald needs to accept ipv6 ping and reply with an ipv6 pong #117

Open
moodyjon opened this issue Dec 22, 2022 · 0 comments · May be fixed by #119
Open

Herald needs to accept ipv6 ping and reply with an ipv6 pong #117

moodyjon opened this issue Dec 22, 2022 · 0 comments · May be fixed by #119
Assignees
@moodyjon
Labels
area: herald new feature

Comments

@moodyjon
Copy link
Contributor

While working on: lbryio/lbry-sdk#3630

I discovered that herald ping/pong packets play a key role in letting lbry-sdk determine the "external IP". Herald needs to accept ipv6 ping and reply with an ipv6 pong containing the client's ipv6 address.

For testing purposes, it's sufficient to use ::1 (localhost), but to really deploy this we will need the external IP address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moodyjon moodyjon

Labels
area: herald new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add IPv6 support to StatusServer and related classes. moodyjon/hub
1 participant
@moodyjon