-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# of confirmations not calculated correctly #57
Comments
@akinwale / @nikooo777 you think you'd be able to take a look at this one soon? Community members are noticing it as well. |
So we no longer keep old transactions that are not included in the leading chain. They are cleared. So technically we only have to take current height or max block height and subtract the height of the block in question. I have this in my @tzarebczan if they cannot get to it. I should have the ppv completed tonight. So I can probably make this one the next highest priority. |
Looks like we had a fix, which worked for some, but if you look at https://explorer.lbry.com/address/bSSfLmehtc3PsDoj1ZDNmYkTbrNiTPj2CW the confirmations are not shown correctly on the top blocks. |
Also the block page does show the right confirmation. Its just this list apparently. |
The old fix from 667097f#diff-84d5d8e3196d5767f5a47b5871946dddR598 can be adapted for this. Essentially, we just need to obtain the max block height and then subtract the height of the corresponding transaction from the max height. |
It shows 1 confirmation on block and transaction pages.
The text was updated successfully, but these errors were encountered: