Date now converts to overridden type #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fixed spelling of overriden -> overridden An alternative to this would be just to bypass `$ref` whenever there is an overridden type. It still throws the error. It happens at: https://github.com/lbovet/typson/blob/master/lib/typson.js#L86 Not sure what solution should be used to silence the error. Could check if the value in `semanticDiagnostics` is in the array `overriddenTypes`. But I would need to create a new file that both files can call. Of course, we could just let the error pass through, just annoying though when a person is using error checking. fixes #16
Buffer is sometimes used for mongoose schema. It is nice to be able to have multiple types on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fixed spelling of overriden -> overridden
An alternative to this would be just to bypass
$refwhenever there is an overridden type.It still throws the error. It happens at:
https://github.com/lbovet/typson/blob/master/lib/typson.js#L86
Not sure what solution should be used to silence the error. Could check if the value in
semanticDiagnosticsis in the arrayoverriddenTypes. But I would need to create a new file that both files can call. Of course, we could just let the error pass through, just annoying though when a person is using error checking.fixes #16