-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Spawn to EnergyPlus 24.2.0 #3911
Comments
May I ask how this is moving along? An update soon to a more recent EnergyPlus version would be much needed here, as the IDFVersion Updater does not allow to downgrade. |
I expect to issue a release in the next couple of months. |
I posted a early buiild for Linux that supports EnergyPlus 24.1.0 here I'm moving forward on a branch that folds in the new autosizing variables. My preference is to wrap this up and then do an update that includes the EnergyPlus update and the autosizing update, but if you want to roll out the EnergyPlus update by itself we could do that. |
I am currently in a situation where it was not clear from the beginning that I would be using SOEP and I was not aware that it was based on EnergyPlus 9.6.0. Therefore, I spent two months creating eight building models in OpenStudio-1.7.1/EnergyPlus-23.2.0 that I would have to manually downgrade to EnergyPlus 9.6.0 in order to use them with SOEP. If the EnergyPlus update could be released on its own, I would be very grateful, but if it disrupts your intended workflow too much, I understand. |
Can you use Linux or do you need a windows build? |
I am unfortunately dependent on Windows because our Dymola licenses are used on Windows PCs. |
@kbenne : I tested an intermediate release on branch On Dymola, this fails with
Did anything regarding handling the idd file change? The idd file is here after the crash: $ find . -name Energy+.idd
./Resources/bin/Spawn-light-0.6.0-69002307aa/linux64/etc/Energy+.idd
./spawn-Unconditioned/resources/Energy+.idd It looks like E+ expects it in the working directory rather than picking the one from |
@kbenne : Kyle, did you isolate what causes this change in idd handling, and is the path forward to recreate the old behavior (as with the current Spawn coupling). |
@mwetter as we discussed via email, I updated the IDF files from v24.1.0 to v24.2.0 here. Can you create the remaining directories and files to support 24.2.0? There is one more thing, which is that as of v24.2.0 EnergyPlus has dropped support for Ubuntu 20.04 and now the minimum version is Ubuntu 22.04. Should we follow? |
Yes. idd path issues are resolved now. |
@mwetter These are based on EnergyPlus v24.2.0a. My tests are functional and qualitative. You will have better quantitative tests. We should expect some change in the results, but I will be interested to learn what the magnitude of the difference is. https://spawn.s3.amazonaws.com/custom/Spawn-light-0.6.0-3794215efe-Linux.tar.gz |
@kbenne : Thanks for the binaries. I tested them on
at every time step, and the simulation takes about 30 seconds for 1 day. (This model should take almost no time to simulate a day.) Can you please look into this and add a test to write to |
Thank you for testing @mwetter. I do have tests on the surface IO, but I didn't notice the perfermance regression. I think I can fix this today. |
@mwetter These should fix the performance regression. https://spawn.s3.us-east-1.amazonaws.com/custom/Spawn-light-0.6.0-db168408b0-Linux.tar.gz |
@kbenne : The warnings go away, but the reported units are wrong: In 9.6.0 (as on the master branch), I get for this model
With today's version, I get
|
@kbenne : Another new issue are the |
1. In _TAveInlet variable, fix the value for "causality". There was extra padding, " input ", when we want "input". 2. Fixed the units custom output variables, which we left at the default "one", because the unit initialization happened *after* the metadata generation. ref lbl-srg/modelica-buildings#3911 (comment) ref lbl-srg/modelica-buildings#3911 (comment)
Hi @mwetter. Here are corrections related to units and the causality attribute. https://spawn.s3.us-east-1.amazonaws.com/custom/Spawn-light-0.6.0-0eed8d916f-Linux.tar.gz I also validated the generated FMUs with fmpy's validator and there are a couple of warnings still remaining. I don't think that these remaining items are regressions, I think they are long standing, but in any case I am working on corrections and will issue another update within one or two days. |
@kbenne : Here is some feedback from testing with the latest E+ binaries.
for the model For the
So let's fix this so we are not cluttering up the output and possible truncating real errors.
But there is only one
|
fmpy validation still reports two warnings about the xml metadata. * ModelStructure/Outputs must have exactly one entry for each variable with causality="output". * ModelStructure/InitialUnknowns does not contain the expected set of variables. We have not historically defined these elements, but may consider adding them in a future commit. ref lbl-srg/modelica-buildings#3911 (comment)
Prior to this, every Spawn zone received a default people input object, which was to avoid errors when accessing the people related outputs for zones without people (such as attics). As of version 24.2, EnergyPlus will issue a warning if there are duplicate people inputs with different PMV, so to avoid such a possible error the default people input is only provided when there is not an existing people input for a particular zone. ref lbl-srg/modelica-buildings#3911 (comment)
This change corrects a regression that prevented "unconnected" zones from updating. ref lbl-srg/modelica-buildings#3911 (comment)
No description provided.
The text was updated successfully, but these errors were encountered: