Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the Add icon code that was present in MenuIcon.tsx with MenuIcon #770

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Changed the Add icon code that was present in MenuIcon.tsx with MenuIcon #770

merged 1 commit into from
Oct 25, 2024

Conversation

NishantSinghhhhh
Copy link
Contributor

@NishantSinghhhhh NishantSinghhhhh commented Oct 23, 2024 •
edited
Loading

Notes for Reviewers

This PR fixes an issue where the AddIcon code was mistakenly used for the MenuIcon. Now, the correct MenuIcon code is in place, resolving the visual discrepancy.

The issue number is #769
Signed commits

  • Yes, I signed my commits.

@NishantSinghhhhh
Copy link
Contributor Author

@amitamrutiya , sir can you please tell me what changes that I need to do , so that I can make this PR mergeable into the master branch.

amitamrutiya
amitamrutiya approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@amitamrutiya amitamrutiya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NishantSinghhhhh for your sharp eyes on this issue. Keep contributing like this. For next time rather than create direct PR please create an issue first and tag any mainter. They will assign you and after that make a PR.

@amitamrutiya
Copy link
Contributor

Ohh you already created an issue @NishantSinghhhhh . Thanks again you are following good prectices. Please link the issue number in PR description so it is easy to maintain and track.

@NishantSinghhhhh
Copy link
Contributor Author

Ohh you already created an issue @NishantSinghhhhh . Thanks again you are following good prectices. Please link the issue number in PR description so it is easy to maintain and track.

okay sir , i will remeber this from next time

@amitamrutiya amitamrutiya merged commit 98a5d96 into layer5io:master Oct 25, 2024
8 checks passed
@nebula-aac nebula-aac mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitamrutiya amitamrutiya Awaiting requested review from amitamrutiya

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NishantSinghhhhh @amitamrutiya