-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing stories #68
Conversation
Signed-off-by: Kunaldeep singh <[email protected]>
@kunal70006 good stuff |
Signed-off-by: Kunaldeep singh <[email protected]>
I also converted all stories to ts just so we can get more controls and stuff |
Signed-off-by: Kunaldeep singh <[email protected]>
Signed-off-by: Kunaldeep singh <[email protected]>
…6/60 Signed-off-by: Kunaldeep singh <[email protected]>
1639170
to
58c7d0d
Compare
Signed-off-by: Kunaldeep singh <[email protected]>
58c7d0d
to
bf26080
Compare
Signed-off-by: Kunaldeep singh <[email protected]>
@nebula-aac you can review this one now, i'll update the description to add the list of components that i covered |
okay, ill provide my feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my review.
Before you get started, update your forked branch to include the latest changes. I opened a PR to include the missing exports from Accordion.
- Add these packages to
design-system
"@layer5/sistent-components": "*",
"@layer5/sistent-svg": "*",
Once you have done this, you will be able to use the packages locally. If it is not does work right away, from the root workspace run yarn build-all
in order to build the artifacts. Either way, you still need the two above added to design-system
package.
- Add
tsconfig.json
, since you're suggesting to change toTypescript
, please make this change the same throughout the entiredesign-system
repo. There are some files that have the.jsx
extensions. You can review existingVite
templates that has these config.
Once you have made the above changes, I can review again.
Signed-off-by: Kunaldeep singh <[email protected]>
Signed-off-by: Kunaldeep singh <[email protected]>
Signed-off-by: Kunaldeep singh <[email protected]>
hey @kunal70006 |
hey @Ghat0tkach I think it's already added in the word doc, do I need to do anything else? Also, can you tell me how long the meeting actually lasts because I've a blocker around 6PM IST/7:30AM CST(i think) so I'm only available from 7-7:30 Central |
At this time, the design system isn't working for me. I'm creating another PR to convert the entire design system to Typescript from scratch. |
what errors are you facing? do you want to discuss? |
Notes for Reviewers
This PR fixes #60
Components covered
Signed commits