build(repo): Setup eslint in root workspace
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kflow fix #361 fix Signed-off-by: Antonette Caldwell <[email protected]>
github-actions
bot
added
area/ci
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Got it. 👍 |
|
|
Signed-off-by: Lee Calcote <[email protected]>
|
Fixed merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two different things.
lint.yml, which was using an outdated actions and did not have the proper flow to install and make sure to use different Node.js versions in a matrix.eslintand relevant packages such as@babel/core@babel/eslint-parsereslint-config-nexteslint-config-standardeslint-plugin-importeslint-plugin-neslint-plugin-promiseeslint-plugin-reactprettier-eslintprettier-eslint-cli@typescript-eslint/eslint-plugin@typescript-eslint/parsereslint-plugin-react-refresheslint-plugin-storybookeslint-plugin-react-hooksprettier-eslintworks a bit better then the*-configand*-plugin, by attaching itself as a process to be used witheslint --fix.At this time, we have
eslintto fix and thenprettierto format files as needed, but if we were to switch it around, there would be leftover files that still needs to be added to git commit.The
eslint-config-sistentpackage is not complete, but will be useful in the near future in Meshery UI and Meshery Cloud UI, to share configuration and plugins across multiple repos. This helps to implement DRY, and keep tech debt down to just one place.The files have been linted and formatted before ignore
siteandnext-12as they will return erroneous errors which will cause more headache then needed at this time to troubleshoot or configure.It will be on a roadmap to ensure that these are properly configured.
The above
eslint-config-sistentwill need to be revised for the future flat config thateslintwill be supporting from now on inv9, but it is optional inv8right now.fix #361
fix #360
Notes for Reviewers
This PR also updates to ignore
design-systemuntil I can figure the best way to lint Storybook specific separately.Signed commits