Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Create Activity Toolbar component #118

Closed
nebula-aac opened this issue Oct 3, 2023 · 4 comments · Fixed by #122
Closed

[components] Create Activity Toolbar component #118

nebula-aac opened this issue Oct 3, 2023 · 4 comments · Fixed by #122
Labels
kind/enhancement Improvement in current feature

Comments

@nebula-aac
Copy link
Contributor

nebula-aac commented Oct 3, 2023

Review existing implementation in Meshery Cloud.


Contributor Guide

@nebula-aac nebula-aac added the kind/enhancement Improvement in current feature label Oct 3, 2023
@sudhanshutech
Copy link
Member

sudhanshutech commented Oct 4, 2023

Existing implementation have:

  • Expandable search, filter, view columns(of data-tables) and grid/table view(where required)
  • Filter has functionality to take options that are supported from backend and filter accordingly
  • Column takes info from data-tables to show/hide columns
  • Search is expandable which will have debounce method implemented
  • At certain width(768px) when search expands other buttons(like create or add) will be hidden, for that mandatory props(expanded, setexpanded) is passed

@toth2000
Copy link
Member

toth2000 commented Oct 4, 2023

@nebula-aac @sudhanshutech are you folks referring to this component below?
image

@sudhanshutech
Copy link
Member

@toth2000 no not in dashboard, except dashboard you will find in all other pages:
image

@toth2000
Copy link
Member

toth2000 commented Oct 5, 2023

@sudhanshutech Could you please assist me by providing the Meshery Cloud repository link? Thank you!

@nebula-aac nebula-aac linked a pull request Oct 6, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Development

Successfully merging a pull request may close this issue.

3 participants