Merge pull request #553 from captain-Akshay/master

feat(icon): fixed the icon used for feedback
layer5io · Mar 26, 2024 · fde826f · fde826f
2 parents 77f55b7 + 2649d1d
commit fde826f
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 19 deletions.
diff --git a/src/custom/Feedback/FeedbackButton.tsx b/src/custom/Feedback/FeedbackButton.tsx
@@ -8,7 +8,7 @@ import {
   QuestionIcon,
   SuccessIcon
 } from '../../icons';
-import { CULTURED, KEPPEL } from '../../theme';
+import { CULTURED } from '../../theme';
 import { CustomTooltip } from '../CustomTooltip';
 import { ModalCard } from '../ModalCard';
 import {
@@ -55,7 +55,7 @@ interface FeedbackDataItem {
 
 const feedbackData: FeedbackDataItem[] = [
   {
-    icon: <FeedbackIcon secondaryFill={KEPPEL} />,
+    icon: <FeedbackIcon />,
     label: 'Issue',
     placeholder: 'I’m having an issue with...',
     isTextInput: true

diff --git a/src/custom/Feedback/style.tsx b/src/custom/Feedback/style.tsx
@@ -268,10 +268,12 @@ export const FeedbackOptionButton = styled(Button)<FeedbackMessageProps>(({ them
     ? SNOW_WHITE
     : SNOW_WHITE,
   fill: isOpen ? (theme.palette.mode === 'dark' ? CULTURED : DARK_PRIMARY_COLOR) : CULTURED,
+  stroke: isOpen ? SNOW_WHITE : KEPPEL,
   '&:hover': {
     color: theme.palette.mode === 'dark' ? SNOW_WHITE : BLACK,
     fill: theme.palette.mode === 'dark' ? CULTURED : DARK_PRIMARY_COLOR,
-    backgroundColor: WHITE
+    backgroundColor: WHITE,
+    stroke: SNOW_WHITE
   }
 }));
 

diff --git a/src/icons/Calender/CalenderIcon.tsx b/src/icons/Calender/CalenderIcon.tsx
@@ -10,6 +10,7 @@ const CalenderIcon: FC<IconProps> = ({ width, height, ...props }) => {
       version="1.1"
       xmlns="http://www.w3.org/2000/svg"
       viewBox="0 0 19 24"
+      stroke="none"
       {...props}
     >
       <path d="M14 9H4V11H14V9Z" />

diff --git a/src/icons/Feedback/FeedbackIcon.tsx b/src/icons/Feedback/FeedbackIcon.tsx
@@ -21,23 +21,12 @@ const FeedbackIcon: FC<KeppelApplicationIconProps> = ({
       fill={props.fill}
       {...props}
     >
-      <path d="M20 2H4C2.9 2 2.01 2.9 2.01 4L2 22L6 18H20C21.1 18 22 17.1 22 16V4C22 2.9 21.1 2 20 2ZM13 14H11V12H13V14ZM13 10H11V6H13V10Z" />
-      <line
-        x1="12"
-        y1="6"
-        x2="12"
-        y2="10"
-        stroke={props.secondaryFill || 'transparent'}
-        stroke-width="2"
-      />
-      <line
-        x1="12"
-        y1="12"
-        x2="12"
-        y2="14"
-        stroke={props.secondaryFill || 'transparent'}
-        stroke-width="2"
+      <path
+        stroke="none"
+        d="M20 2H4C2.9 2 2.01 2.9 2.01 4L2 22L6 18H20C21.1 18 22 17.1 22 16V4C22 2.9 21.1 2 20 2ZM13 14H11V12H13V14ZM13 10H11V6H13V10Z"
       />
+      <line x1="12" y1="6" x2="12" y2="10" stroke="inherit" stroke-width="2" />
+      <line x1="12" y1="12" x2="12" y2="14" stroke="inherit" stroke-width="2" />
     </svg>
   );
 };

diff --git a/src/icons/Idea/IdeaIcon.tsx b/src/icons/Idea/IdeaIcon.tsx
@@ -10,6 +10,7 @@ const IdeaIcon: FC<IconProps> = ({ width = DEFAULT_WIDTH, height = DEFAULT_HEIGH
       version="1.1"
       xmlns="http://www.w3.org/2000/svg"
       viewBox="0 0 15 24"
+      stroke="none"
       {...props}
     >
       <path d="M7.49634 0C3.81658 0 0.833008 3.0072 0.833008 6.71664C0.833008 7.938 1.17348 9.07344 1.72134 10.0702C3.35777 13.0418 3.7911 14.7106 4.05801 16.3255C4.28206 17.6794 4.59206 17.9938 5.60658 17.9938C6.03801 17.9938 6.74444 17.9938 7.49634 17.9938C8.24825 17.9938 8.95467 17.9938 9.38586 17.9938C10.4009 17.9938 10.7106 17.6789 10.9347 16.3255C11.2016 14.7106 11.6351 13.0416 13.2716 10.0702C13.8197 9.07368 14.1597 7.938 14.1597 6.71664C14.1599 3.0072 11.1763 0 7.49634 0Z" />