Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/prettier #5702

Closed
wants to merge 7 commits into from
Closed

feat/prettier #5702

wants to merge 7 commits into from

Conversation

dottharun
Copy link
Contributor

@dottharun dottharun commented Jul 19, 2024 •
edited
Loading

Description

This PR adds Prettier to the Project.

Todo:

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/landscape The service mesh landscape project/meshery area/news A noteworthy article, event, happening area/blog New posts or new blog functionality area/projects An issue relating to Layer5 initiatives (projects) area/community area/learn Related to /learn section area/events area/careers area/resources area/handbook project/kanvas area/site-config area/ci area/core-styles labels Jul 19, 2024
@l5io
Copy link
Contributor

l5io commented Jul 19, 2024

🚀 Preview for commit 02595b7 at: https://669aea0d941377c18cf1e0d5--layer5.netlify.app

@dottharun dottharun force-pushed the feat/prettier branch 4 times, most recently from 1448dbc to eb4a36b Compare July 20, 2024 21:05
@l5io
Copy link
Contributor

l5io commented Jul 20, 2024

🚀 Preview for commit eb4a36b at: https://669c29ea1a7db43ce79ec790--layer5.netlify.app

@dottharun dottharun marked this pull request as ready for review July 20, 2024 21:38
leecalcote
leecalcote requested changes Jul 20, 2024
View reviewed changes
.prettierrc Outdated Show resolved Hide resolved
@l5io
Copy link
Contributor

l5io commented Jul 21, 2024

🚀 Preview for commit e97440c at: https://669c6befec49536b9cb3313e--layer5.netlify.app

@sudhanshutech
Copy link
Member

@dottharun merge conflicts

@leecalcote
Copy link
Member

@dottharun is this needed any longer?

@dottharun
Copy link
Contributor Author

dottharun commented Jul 27, 2024 •
edited
Loading

@dottharun is this needed any longer?

This PR is for the prettier change (formatting) - the other PRs #5680 #5719 was for
eslint config (logic) only.

@dottharun
Copy link
Contributor Author

@dottharun merge conflicts

Fixed it.

@l5io
Copy link
Contributor

l5io commented Jul 27, 2024

🚀 Preview for commit f412082 at: https://66a503f6b95c2e2793c98724--layer5.netlify.app

@sudhanshutech
Copy link
Member

sudhanshutech commented Jul 29, 2024 •
edited
Loading

@dottharun merge conflicts. this will keep on having on merge conflicts. Please do sound if its ready to merge and you have tested properly

@sudhanshutech
Copy link
Member

@dottharun ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote requested changes

Assignees
No one assigned
Labels
area/blog New posts or new blog functionality area/careers area/ci area/community area/core-styles area/events area/handbook area/landscape The service mesh landscape area/learn Related to /learn section area/news A noteworthy article, event, happening area/projects An issue relating to Layer5 initiatives (projects) area/resources area/site-config project/kanvas project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dottharun @l5io @sudhanshutech @leecalcote