-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Sistent page UI bugs (Small devices) #5697
Conversation
Signed-off-by: Muhammad Moinuddin <[email protected]>
🚀 Preview for commit a0f2f5a at: https://669a61d6e72c6439a5457357--layer5.netlify.app |
@@ -21,6 +21,9 @@ const SistentWrapper = styled.div` | |||
.content { | |||
width: 100%; | |||
padding-bottom: 2rem; | |||
@media only screen and (max-width: 425px){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we are not opening the dropdown above max width 425, it should open until the dropdown is displaying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we are not opening the dropdown above max width 425, it should open until the dropdown is displaying
It will appear, this query is for .content not for dropdown. It is basically making .content overflow to be hidden on smaller screens so that dropdown can work. You can verify that via commit preview url.
@Muhammed-Moinuddin Can I resolve this issue ??? Pls reply asap As I am a new comer at Layer5 so I might need some guidance |
There's nothing to resolve over here. |
@Muhammed-Moinuddin, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
Signed-off-by: Muhammad Moinuddin <[email protected]>
This reverts commit 72379b2. Signed-off-by: Muhammad Moinuddin <[email protected]>
🚀 Preview for commit a7291a3 at: https://66a0064c5b0d382b26d2186f--layer5.netlify.app |
@Muhammed-Moinuddin have you fixed that dropdown bug? |
Yes. Just need to push it. |
@sudhanshutech closing this PR. Will raise new one for the issue. |
Description
Resolved Horizontal scrolling, Dropdown and Table of Content button issue on small devices. This PR does not make changes in Handbook CSS (was done to prevent conflicts from other PRs/Issues).
This PR fixes #5677
Notes for Reviewers
Signed commits