Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Sistent page UI bugs (Small devices) #5697

Closed
wants to merge 6 commits into from

Conversation

Muhammed-Moinuddin
Copy link
Contributor

Description
Resolved Horizontal scrolling, Dropdown and Table of Content button issue on small devices. This PR does not make changes in Handbook CSS (was done to prevent conflicts from other PRs/Issues).

This PR fixes #5677

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 19, 2024

🚀 Preview for commit a0f2f5a at: https://669a61d6e72c6439a5457357--layer5.netlify.app

@@ -21,6 +21,9 @@ const SistentWrapper = styled.div`
.content {
width: 100%;
padding-bottom: 2rem;
@media only screen and (max-width: 425px){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we are not opening the dropdown above max width 425, it should open until the dropdown is displaying

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we are not opening the dropdown above max width 425, it should open until the dropdown is displaying

It will appear, this query is for .content not for dropdown. It is basically making .content overflow to be hidden on smaller screens so that dropdown can work. You can verify that via commit preview url.

@Shubhf
Copy link

Shubhf commented Jul 20, 2024

@Muhammed-Moinuddin Can I resolve this issue ??? Pls reply asap As I am a new comer at Layer5 so I might need some guidance

@Muhammed-Moinuddin
Copy link
Contributor Author

@Muhammed-Moinuddin Can I resolve this issue ??? Pls reply asap As I am a new comer at Layer5 so I might need some guidance

There's nothing to resolve over here.
Would love to help you.

@leecalcote leecalcote added the area/projects An issue relating to Layer5 initiatives (projects) label Jul 20, 2024
@Ashparshp
Copy link
Contributor

@Muhammed-Moinuddin, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Jul 23, 2024

🚀 Preview for commit a7291a3 at: https://66a0064c5b0d382b26d2186f--layer5.netlify.app

@sudhanshutech
Copy link
Member

@Muhammed-Moinuddin have you fixed that dropdown bug?

@Muhammed-Moinuddin
Copy link
Contributor Author

@Muhammed-Moinuddin have you fixed that dropdown bug?

Yes. Just need to push it.
Messed up some commits and need to sort them out first.

@Muhammed-Moinuddin
Copy link
Contributor Author

@sudhanshutech closing this PR. Will raise new one for the issue.

@Muhammed-Moinuddin Muhammed-Moinuddin deleted the master branch July 24, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects)
Development

Successfully merging this pull request may close these issues.

[UI] Horizontal scrolling, Dropdown and Table of Content button issue on small devices
7 participants