Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5640 abjustlayout #5647

Closed

Conversation

pukarlamichhane
Copy link

@pukarlamichhane pukarlamichhane commented Jul 7, 2024

Description

This PR fixes #5640

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 7, 2024

🚀 Preview for commit 5087bb0 at: https://668a92c2757d6ae9a040720b--layer5.netlify.app

@sudhanshutech
Copy link
Member

@pukarlamichhane make sure you add the issue number in pr message not in title so it will link with appropriate issue.
Also ensure you sign your commits please

Copy link

github-actions bot commented Jul 7, 2024

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

github-actions bot commented Jul 7, 2024

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

const LabSinglePage = ({ frontmatter, body }) => {

// React.useEffect(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?


.backBtn {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid doing unnecessary lint changes please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sir

@vishalvivekm
Copy link
Member

@pukarlamichhane
Thank you for your contribution.
Let's discuss this on Websites' call. Adding this as an agenda item into the meeting minutes.

@Ashparshp
Copy link
Contributor

@pukarlamichhane Make sure to sign-off commits..

@sudhanshutech
Copy link
Member

@pukarlamichhane any progress further?

@pukarlamichhane
Copy link
Author

pukarlamichhane commented Jul 19, 2024 via email

@Ashparshp
Copy link
Contributor

@pukarlamichhane Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Jul 23, 2024

🚀 Preview for commit da441c0 at: https://66a02de54c78b354a02dfe8f--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@pukarlamichhane Sign-off Please..

@sudhanshutech
Copy link
Member

@pukarlamichhane checking again?

@Ashparshp
Copy link
Contributor

@pukarlamichhane, Final check..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

The text and layout need to be adjusted for better readability and usability across different screen sizes.
5 participants