-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 5640 abjustlayout #5647
Issue 5640 abjustlayout #5647
Conversation
Signed-off-by: pukarlamichhane <[email protected]>
🚀 Preview for commit 5087bb0 at: https://668a92c2757d6ae9a040720b--layer5.netlify.app |
@pukarlamichhane make sure you add the issue number in pr message not in title so it will link with appropriate issue. |
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
1 similar comment
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
const LabSinglePage = ({ frontmatter, body }) => { | ||
|
||
// React.useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this?
|
||
.backBtn { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid doing unnecessary lint changes please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sir
@pukarlamichhane |
@pukarlamichhane Make sure to sign-off commits.. |
@pukarlamichhane any progress further? |
Already completed
…On Fri, 19 Jul 2024, 22:38 Sudhanshu Dasgupta, ***@***.***> wrote:
@pukarlamichhane <https://github.com/pukarlamichhane> any progress
further?
—
Reply to this email directly, view it on GitHub
<#5647 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZ745SUYUJYZ34IJLYTIVSTZNFABTAVCNFSM6AAAAABKPKZ4VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZGYZTENZSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@pukarlamichhane Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
🚀 Preview for commit da441c0 at: https://66a02de54c78b354a02dfe8f--layer5.netlify.app |
@pukarlamichhane Sign-off Please.. |
@pukarlamichhane checking again? |
@pukarlamichhane, Final check.. |
Description
This PR fixes #5640
Notes for Reviewers
Signed commits