Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed role options color #5233

Closed
wants to merge 1 commit into from

Conversation

akshat-kaushik
Copy link

@akshat-kaushik akshat-kaushik commented Dec 26, 2023

Description

This PR fixes #5232

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Dec 26, 2023

🚀 Preview for commit b96d01a at: https://658a773f58d63a6c8d20bee0--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 26, 2023

🚀 Preview for commit b96d01a at: https://658a7ed056d73470b2d1a2de--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this, @akshat-kaushik 👍

Let's avoid mandating white background and black text. Instead, these colors should change (invert) based on light vs dark mode.

Screenshot 2023-12-28 at 8 30 55 AM

Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@saurabh100ni
Copy link
Contributor

Hey @akshat-kaushik ,
Thanks for raising the PR, Please add this as your agenda in Doc to discuss it in the Website Meeting tomorrow at 6:30 PM IST.

Subscribe to community calendar for more details of meetings at Layer5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[BUG] Options not visible in roles dropdown list on meshmap page
4 participants