Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable modal for images with data-modal="false" in docs pages #402

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

vishalvivekm
Copy link
Member

@vishalvivekm vishalvivekm commented Oct 28, 2024

Notes for Reviewers

This PR fixes
image

  • currently, all imgs are opened in modal on pages using docs layout causing the nav grid icon to malfunction, the pr prevents this behaviour for imgs that have data-modal attribute set as false ( we an just set the attribute for such other opt-out icons as well)

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 24a55af
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/671fef0bfbdf180008f40df8
😎 Deploy Preview https://deploy-preview-402--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member Author

@leecalcote
This was a bug in the site due to which, from any docs page when clicked all the <img /> elements would open in modal including the footer icons. e.g.
Screenshot from 2024-10-29 01-45-00

I fixed this here.

@vishalvivekm vishalvivekm merged commit 7462f99 into layer5io:master Oct 28, 2024
6 checks passed
@leecalcote
Copy link
Member

Ooooh, I see. Ok, yeah.

@leecalcote
Copy link
Member

Thanks for getting this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants