-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #391
Update README.md #391
Conversation
Update the subsequent screen shot Signed-off-by: Manvendra <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @Manvendra2000. Will you please instead remove this image and copy/paste the text, checkmarks, and community icon from https://github.com/layer5io/layer5/blob/master/README.md ?
Updated the image and text, rather than image. Signed-off-by: Manvendra <[email protected]>
For Sure! here it is @leecalcote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
README.md
Outdated
@@ -1,5 +1,13 @@ | |||
![image](https://github.com/user-attachments/assets/0d802112-175c-437b-947f-a63b8b483436) # Layer5 Product Documentation | |||
|
|||
<div class="flex"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is flex used on the original readme? I'd be surprised if GFMD supported this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @leecalcote I have removed class="flex" in the new commit. Apart from that the in the doc in meshary/readme.md line 313 below is the screenshot, flex is being used. should I work on this issue
Signed-off-by: Manvendra <[email protected]>
@Manvendra2000 Please add it as an agenda item to the meeting minutes. |
@vishalvivekm I have added the the issue to Agenda of meeting. |
Co-authored-by: Vivek Vishal <[email protected]> Signed-off-by: Manvendra <[email protected]>
Consolidated the pointers into a single line and improved the documentation's readability.
Notes for Reviewers
This PR fixes #
Updated the subsequent screenshot
Signing off as Manvendra [[email protected]]
Signed commits