Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #391

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Update README.md #391

merged 5 commits into from
Oct 25, 2024

Conversation

Manvendra2000
Copy link
Contributor

@Manvendra2000 Manvendra2000 commented Oct 15, 2024

Consolidated the pointers into a single line and improved the documentation's readability.

Notes for Reviewers

This PR fixes #
Updated the subsequent screenshot

Signing off as Manvendra [[email protected]]

Signed commits

  • [✅ ] Yes, I signed my commits.

Update the subsequent screen shot 

Signed-off-by: Manvendra <[email protected]>
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 98769bd
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/67174c7b7f12610008ca4138
😎 Deploy Preview https://deploy-preview-391--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @Manvendra2000. Will you please instead remove this image and copy/paste the text, checkmarks, and community icon from https://github.com/layer5io/layer5/blob/master/README.md ?

Updated the image and text, rather than image.


Signed-off-by: Manvendra <[email protected]>
@Manvendra2000
Copy link
Contributor Author

Thanks for this, @Manvendra2000. Will you please instead remove this image and copy/paste the text, checkmarks, and community icon from https://github.com/layer5io/layer5/blob/master/README.md ?

For Sure! here it is @leecalcote

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Outdated
@@ -1,5 +1,13 @@
![image](https://github.com/user-attachments/assets/0d802112-175c-437b-947f-a63b8b483436) # Layer5 Product Documentation

<div class="flex">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is flex used on the original readme? I'd be surprised if GFMD supported this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leecalcote I have removed class="flex" in the new commit. Apart from that the in the doc in meshary/readme.md line 313 below is the screenshot, flex is being used. should I work on this issue image

@leecalcote
Copy link
Member

@Manvendra2000 https://layer5io.slack.com/archives/C019426UBNY/p1729177173523569

Signed-off-by: Manvendra <[email protected]>
@vishalvivekm
Copy link
Member

@Manvendra2000
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@Manvendra2000
Copy link
Contributor Author

@vishalvivekm I have added the the issue to Agenda of meeting.

README.md Outdated Show resolved Hide resolved
@leecalcote leecalcote merged commit 4c3451e into layer5io:master Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants