Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Includes steps to sign off commits #374 #384

Merged
merged 4 commits into from
Oct 6, 2024

Conversation

csengineer1990
Copy link
Contributor

Notes for Reviewers
I have added instructions on how to sign off commits to meet the Developer Certificate of Origin (DCO) requirements in the file CONTRIBUTING-gitflow.md. Could you please review it and let me know if there are any issues or if any further adjustments are needed?
This PR fixes #374

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 5ab03c3
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/66ff63d12532cd0008acac91
😎 Deploy Preview https://deploy-preview-384--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @csengineer1990 👍

@leecalcote leecalcote merged commit b3c88c0 into layer5io:master Oct 6, 2024
6 checks passed
@csengineer1990
Copy link
Contributor Author

csengineer1990 commented Oct 7, 2024

Thank you so much @leecalcote

I have a small request, Sir. Could you please label this issue/PR/MR as "Hacktoberfest" or "Hacktoberfest-accepted"?

Thank you for your consideration!

@leecalcote leecalcote added the hacktoberfest Happy contributing! label Oct 7, 2024
@leecalcote
Copy link
Member

@csengineer1990 you bet. 👍

@csengineer1990
Copy link
Contributor Author

Thank you so much, @leecalcote! I really appreciate it. Looking forward to contributing further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Docs] Include steps to sign off commits
2 participants