Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic rate limiting #47

Open
ddevault opened this issue Mar 21, 2020 · 3 comments
Open

Automatic rate limiting #47

ddevault opened this issue Mar 21, 2020 · 3 comments

Comments

@ddevault
Copy link

mumble-voip/mumble#3510

This patch added rate limiting to mumble upstream, which simply drops messages if they're sent too quickly. I ran into this while working on a bot and it took me a bit to figure out that this was the reason my messages were being dropped. It would be nice if gumble had built-in throttling.

@ghost ghost added the feature-request label Mar 21, 2020
@ghost
Copy link

ghost commented Mar 21, 2020

Do you have any thoughts on the implementation? None of gumble's the sending methods currently have a return value.

@ddevault
Copy link
Author

Maybe you could just accumulate messages to be sent into a queue, then flush them with a rate limit in the main loop of gumbleutil?

@ghost
Copy link

ghost commented Mar 22, 2020

I see the rate limiting is also configurable (see mumble-voip/mumble#3517), so I'm not sure how this could be done reliably on the client-side. I would like to see the server expose its rate limiting options to the client (similar to how the maximum audio bitrate is exposed), before a client-side rate limit is added inside of gumble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant