-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emote cache for faster chat rendering #1244
Comments
Emotes are already cached locally on the disk. The reason it takes a while to fetch emotes is because we decode each image file sequentially. We do it this way because its simpler to handle. We also don't retain the decoded emotes in memory between renders because of both simplicity and for the rare case that emote definitions change while the app is open. |
I would be willing to look into refactoring the image fetching service to parallelize decoding cached images, but I will not be retaining emotes in memory between runs because that opens up a whole host of issues. |
The emotes as far as I know never change, so could not be better to have an assets folder in the project or a zip file where all the known emotes are there? Only fetch the new emotes until the project is updated, or just let the assets folder be updatable separately. this can fix also #1241 |
|
They actually do change sometimes, albeit rarely. |
Checklist
Write your feature request here
Currently you have to spend quite a bit of the chat render process looking up the emotes. There are a lot of universal emotes and editing for a single channel will use the same emotes most of the time and a local cache of emotes would be useful.
The text was updated successfully, but these errors were encountered: