Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to archive site for removed global Twitch emotes #1241

Open
2 tasks done
superbonaci opened this issue Oct 31, 2024 · 4 comments
Open
2 tasks done

Fallback to archive site for removed global Twitch emotes #1241

superbonaci opened this issue Oct 31, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@superbonaci
Copy link
Contributor

superbonaci commented Oct 31, 2024

Checklist

Edition

Command Line Interface

Describe your issue here

Older chats got the emote removed even if it hadn't expired back then. So the url for the image is there but can't be downloaded:

$ TwitchDownloaderCLI chatdownload -E -u 2262876737 -o 2262876737.html
$ TwitchDownloaderCLI chatdownload -E -u 2262876737 -o 2262876737.json

This could happen also to other images. If TwitchDownlaoderCLI can't get the images from twitch it can try from Web Archive.
This affects chatdownload chatupdate chatrender.

chats:
2262876737.html.zip
2262876737.json.zip

Add any related files or extra information here

2262876737

@superbonaci superbonaci added the bug Something isn't working label Oct 31, 2024
@superbonaci superbonaci changed the title BibleThump emote image is missing in older chats but they still appear in the chat BibleThump emote image is missing in older chats but the link still appears in the chat Oct 31, 2024
@ScrubN
Copy link
Collaborator

ScrubN commented Nov 1, 2024

I like the idea of restoring deleted Twitch emotes such as BibleThumb, PogChamp, and BlessRNG, I also don't really want to keep a hard coded list of removed emotes that fallback to archive.org. Maybe I'll change my stance on it later.

@ScrubN ScrubN added enhancement New feature or request and removed bug Something isn't working labels Nov 1, 2024
@ScrubN ScrubN changed the title BibleThump emote image is missing in older chats but the link still appears in the chat Fallback to archive site for removed Twitch emotes Nov 1, 2024
@ScrubN ScrubN changed the title Fallback to archive site for removed Twitch emotes Fallback to archive site for removed global Twitch emotes Nov 1, 2024
@superbonaci
Copy link
Contributor Author

Also OMGScoots.
You could store the images in an assets folder in the project, but I don't know if that is legal. But if you did that you could do it with all emotes, and the program will be much faster.

If you don't hard code the list of removed emotes in the program the only thing you can do is to connect to a website that lists all the removed emotes, and is updated. But I don't know of such website and I don't think it will ever exist.

Using archive.org is simple and fixes the problem now, you can even keep a list of urls for each removed emote in case archive.org closes or something.

@Mishasama
Copy link

Perhaps you can try hosting a service on GitHub.io to cache all these emote images and their corresponding keywords. This way, when the program encounters an emote image that cannot be found on Twitch, it can attempt to search for the corresponding emote image in this service by using keywords from the already downloaded chat files, and if found, download and use it.

@superbonaci
Copy link
Contributor Author

It only depends if ScrubN wants to fix it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants