UCDMIB: Error Flag should be optional, some implimentations don't support it

Author: dhoffend

plugins-scripts/Classes/UCDMIB/Components/DiskSubsystem.pm

@@ -96,12 +96,13 @@ sub check {
   $spaceleft =~ s/(?<=\d)(?=(?:\d\d\d)+\b)/,/g;
   $self->add_info(sprintf '%s has %s MB left (%.2f%%)%s',
       $self->{dskPath}, $spaceleft, $free,
-      $self->{dskErrorFlag} eq 'error'
-          ? sprintf ' - %s', $self->{dskErrorMsg}
-          : '');
+      defined $self->{dskErrorFlag} && defined $self->{dskErrorMsg}
+      	  && $self->{dskErrorFlag} eq 'error'
+        ? sprintf ' - %s', $self->{dskErrorMsg}
+        : '');
 
   # raise critical error if errorflag is set
-  if ($self->{dskErrorFlag} eq 'error') {
+  if (defined $self->{dskErrorFlag} && $self->{dskErrorFlag} eq 'error') {
     $self->add_critical();
   } else {
     # otherwise check thresholds

plugins-scripts/Classes/UCDMIB/Components/LoadSubsystem.pm

@@ -43,11 +43,12 @@ sub check {
   $self->add_info(
       sprintf '%s is %.2f%s',
       lc $self->{laNames}, $self->{laLoad},
-      $self->{'laErrorFlag'} eq 'error'
-          ? sprintf ' (%s)', $self->{'laErrMessage'}
-          : ''
+      $self->{'laErrorFlag'} && defined $self->{'laErrMessage'}
+          && $self->{'laErrorFlag'} eq 'error'
+        ? sprintf ' (%s)', $self->{'laErrMessage'}
+        : ''
   );
-  if ($self->{'laErrorFlag'} eq 'error') {
+  if (defined $self->{'laErrorFlag'} && $self->{'laErrorFlag'} eq 'error') {
     $self->add_critical();
   } else {
     $self->add_message($self->check_thresholds(

plugins-scripts/Classes/UCDMIB/Components/ProcessSubsystem.pm

@@ -47,17 +47,18 @@ sub check {
   $self->add_info(sprintf '%s: %d%s',
       $self->{prNames},
       $self->{prCount},
-      $self->{prErrorFlag} eq 'error'
-          ? sprintf ' (%s)', $self->{prErrMessage}
-          : '');
+      defined $self->{prErrorFlag} && defined $self->{prErrMessage}
+          && $self->{prErrorFlag} eq 'error'
+        ? sprintf ' (%s)', $self->{prErrMessage}
+        : '');
   my $threshold = sprintf '%u:%s',
       !$self->{prMin} && !$self->{prMax} ? 1 : $self->{prMin},
       $self->{prMax} && $self->{prMax} >= $self->{prMin} ? $self->{prMax} : '';
   $self->set_thresholds(
       metric => $self->{prNames},
       warning => $threshold,
       critical => $threshold);
-  if ($self->{prErrorFlag} eq 'error') {
+  if (defined $self->{prErrorFlag} && $self->{prErrorFlag} eq 'error') {
     $self->add_critical();
   } else {
     $self->add_message($self->check_thresholds(