Commit 84b7aca
chore: pin third-party GitHub Actions to commit SHAs (#18)
## Summary
Pin all third-party GitHub Actions to full-length commit SHAs to prevent
supply chain attacks.
Addresses findings from the
[`third-party-action-not-pinned-to-commit-sha`](https://github.com/launchdarkly/semgrep-rules/blob/main/github-actions/third-party-action-not-pinned-to-commit-sha.yml)
Semgrep rule.
### Updates since initial revision
- Version comments now use fully qualified version numbers (e.g. `#
v4.4.0` instead of `# v4`)
- `ruby/setup-ruby` bumped from v1.295.0 (`319994f...`) to **v1.299.0**
(`3ff19f5e2baf30647122352b96108b1fbe250c64`), the latest v1 release
- `googleapis/release-please-action` confirmed at **v4.4.0**
(`16a9c90856f42705d54a6fda1823352bdc62cf38`), already the latest v4
release
Release links for verification:
- [ruby/setup-ruby
v1.299.0](https://github.com/ruby/setup-ruby/releases/tag/v1.299.0)
- [googleapis/release-please-action
v4.4.0](https://github.com/googleapis/release-please-action/releases/tag/v4.4.0)
## Review & Testing Checklist for Human
- [ ] Verify the pinned SHAs match the expected release tags using the
release links above
- [ ] Confirm CI passes with the updated `ruby/setup-ruby` v1.299.0
(bumped from v1.295.0)
### Notes
- The `slsa-framework/slsa-github-generator` reference on line 61 of
`release-please.yml` remains at `@v2.0.0` (floating tag) — this action
[cannot be pinned to a commit
SHA](launchdarkly/ruby-server-sdk#374 (comment)).
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk: changes only pin GitHub Action references to specific
commits, with no functional logic changes beyond potential action
version drift if the pinned SHAs differ from the floating tags.
>
> **Overview**
> Pins third-party GitHub Actions to immutable commit SHAs to harden
CI/release workflows against supply-chain tampering.
>
> Updates `ruby/setup-ruby@v1` usages (composite CI action, Windows CI
job, and docs publish workflow) to a specific commit SHA, and similarly
pins `googleapis/release-please-action@v4` in the release workflow to a
specific `v4.4.0` commit.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
12e5cd3. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Link to Devin session:
https://app.devin.ai/sessions/56bd3c6eff084ef4802aaa48b08ebab6
Requested by: @kinyoklion
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>1 parent 31e7222 commit 84b7aca
File tree
4 files changed
+4
-4
lines changed- .github
- actions/ci
- workflows
4 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments