fix: lots of new Clippy warnings

Author: abonander

benches/sqlite/describe.rs

@@ -3,7 +3,7 @@ use criterion::Criterion;
 use criterion::{criterion_group, criterion_main};
 
 use sqlx::sqlite::{Sqlite, SqliteConnection};
-use sqlx::{Connection, Executor};
+use sqlx::Executor;
 use sqlx_test::new;
 
 // Here we have an async function to benchmark

sqlx-macros-core/src/common.rs

@@ -15,9 +15,9 @@ pub(crate) fn resolve_path(path: impl AsRef<Path>, err_span: Span) -> syn::Resul
     // requires `proc_macro::SourceFile::path()` to be stable
     // https://github.com/rust-lang/rust/issues/54725
     if path.is_relative()
-        && !path
+        && path
             .parent()
-            .map_or(false, |parent| !parent.as_os_str().is_empty())
+            .is_none_or(|parent| parent.as_os_str().is_empty())
     {
         return Err(syn::Error::new(
             err_span,

sqlx-macros-core/src/test_attr.rs

@@ -246,13 +246,9 @@ fn parse_args(attr_args: AttributeArgs) -> syn::Result<Args> {
 
                 fn recurse_lit_lookup(expr: Expr) -> Option<Lit> {
                     match expr {
-                        Expr::Lit(syn::ExprLit { lit, .. }) => {
-                            return Some(lit);
-                        }
-                        Expr::Group(syn::ExprGroup { expr, .. }) => {
-                            return recurse_lit_lookup(*expr);
-                        }
-                        _ => return None,
+                        Expr::Lit(syn::ExprLit { lit, .. }) => Some(lit),
+                        Expr::Group(syn::ExprGroup { expr, .. }) => recurse_lit_lookup(*expr),
+                        _ => None,
                     }
                 }
 

sqlx-mysql/src/connection/establish.rs

@@ -186,7 +186,7 @@ impl<'a> DoHandshake<'a> {
     }
 }
 
-impl<'a> WithSocket for DoHandshake<'a> {
+impl WithSocket for DoHandshake<'_> {
     type Output = Result<MySqlStream, Error>;
 
     async fn with_socket<S: Socket>(self, socket: S) -> Self::Output {

sqlx-mysql/src/connection/executor.rs

@@ -25,7 +25,7 @@ use futures_util::TryStreamExt;
 use std::{borrow::Cow, pin::pin, sync::Arc};
 
 impl MySqlConnection {
-    async fn prepare_statement<'c>(
+    async fn prepare_statement(
         &mut self,
         sql: &str,
     ) -> Result<(u32, MySqlStatementMetadata), Error> {
@@ -72,7 +72,7 @@ impl MySqlConnection {
         Ok((id, metadata))
     }
 
-    async fn get_or_prepare_statement<'c>(
+    async fn get_or_prepare_statement(
         &mut self,
         sql: &str,
     ) -> Result<(u32, MySqlStatementMetadata), Error> {

sqlx-mysql/src/protocol/statement/execute.rs

@@ -11,7 +11,7 @@ pub struct Execute<'q> {
     pub arguments: &'q MySqlArguments,
 }
 
-impl<'q> ProtocolEncode<'_, Capabilities> for Execute<'q> {
+impl ProtocolEncode<'_, Capabilities> for Execute<'_> {
     fn encode_with(&self, buf: &mut Vec<u8>, _: Capabilities) -> Result<(), crate::Error> {
         buf.push(0x17); // COM_STMT_EXECUTE
         buf.extend(&self.statement.to_le_bytes());

sqlx-mysql/src/types/text.rs

@@ -16,7 +16,7 @@ impl<T> Type<MySql> for Text<T> {
     }
 }
 
-impl<'q, T> Encode<'q, MySql> for Text<T>
+impl<T> Encode<'_, MySql> for Text<T>
 where
     T: Display,
 {

sqlx-postgres/src/types/cube.rs

@@ -71,7 +71,7 @@ impl<'r> Decode<'r, Postgres> for PgCube {
     }
 }
 
-impl<'q> Encode<'q, Postgres> for PgCube {
+impl Encode<'_, Postgres> for PgCube {
     fn produces(&self) -> Option<PgTypeInfo> {
         Some(PgTypeInfo::with_name("cube"))
     }

sqlx-postgres/src/types/geometry/box.rs

@@ -56,7 +56,7 @@ impl<'r> Decode<'r, Postgres> for PgBox {
     }
 }
 
-impl<'q> Encode<'q, Postgres> for PgBox {
+impl Encode<'_, Postgres> for PgBox {
     fn produces(&self) -> Option<PgTypeInfo> {
         Some(PgTypeInfo::with_name("box"))
     }

sqlx-postgres/src/types/geometry/circle.rs

@@ -54,7 +54,7 @@ impl<'r> Decode<'r, Postgres> for PgCircle {
     }
 }
 
-impl<'q> Encode<'q, Postgres> for PgCircle {
+impl Encode<'_, Postgres> for PgCircle {
     fn produces(&self) -> Option<PgTypeInfo> {
         Some(PgTypeInfo::with_name("circle"))
     }